Project

General

Profile

Actions

Bug #161

closed

The user-configured order of sentence elements is not being saved

Added by Joseph Potvin over 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Urgent
Assignee:
Category:
Refine
Start date:
09/18/2022
Due date:
% Done:

0%

Estimated time:
Issue closed :
02/13/2023

Description

When I re-order the syntactic elements (either by clicking arrows or drag'n-drop), the new order is not being retained. The sentence always shows with the old order of elements. And when I click to edit it again, the old order is also presented.


Files

Actions #1

Updated by Joseph Potvin over 1 year ago

I have tested this in both Firefox and Chrome, and get the same result.

Actions #2

Updated by Huda Hussain over 1 year ago

  • Status changed from New to Feedback
  • Assignee changed from Huda Hussain to Joseph Potvin
Actions #3

Updated by Joseph Potvin over 1 year ago

This is fixed when the user clicks "Save".

But I cycled through examples, THEN re-ordered one, then clicked "Use Example". This brings me to the logic gate UI with the example shown in its original order.

Instead, please have the "Use Example" link populate the displayed fields, and stay in the sentence editing UI without reverting to the main logic gate UI.

Also please emphasize "Save" on the main sentence editing UI with an obvious button.

Actions #4

Updated by Joseph Potvin over 1 year ago

  • Status changed from Feedback to Closed
Actions #5

Updated by Joseph Potvin about 1 year ago

  • Status changed from Closed to In Progress
  • Assignee changed from Joseph Potvin to Huda Hussain

Hi, this problem is showing up again. It's important to address soon as I am trying to work on examples, and this messes them up.

Actions #6

Updated by Joseph Potvin about 1 year ago

I don't know if the error is on the json export operation, or the json import -- possibly it the import end which is just bringing the elements to their default order.

Actions #7

Updated by Joseph Potvin about 1 year ago

Here is the sample json file attached. In many of the Input Conditions, the phrase "as confirmed via independent audit." (Past Participle Verb) is supposed to be at the END of those sentences.

Actions #8

Updated by Huda Hussain about 1 year ago

Joseph Potvin wrote in #note-7:

Here is the sample json file attached. In many of the Input Conditions, the phrase "as confirmed via independent audit." (Past Participle Verb) is supposed to be at the END of those sentences.

I recently pushed a fix that should cause that error not to occur. However I do want to mention that the order of the values is not saved when when exporting, (therefore will not show up when importing) as the extra values were not in your JSON schema. I can keep the order after export and import, however that will add more values to the json export ofcourse.

Actions #9

Updated by Joseph Potvin about 1 year ago

RE: "however that will add more values to the json export of course"

I can think of two ways to do this:

  1. Export in the order that the user has set the six elements; and on import, use that order for loading.

  2. Export with a number for the order.

I'd prefer the first option, so that when any one is auditing the JSON file, the sentences remain quite readable. Storing them in a mechanically fixed default order in the JSON file can, in many languages, come across and entirely confusing.

Actions #10

Updated by Huda Hussain about 1 year ago

  • Assignee changed from Huda Hussain to Joseph Potvin

I implemented the first suggestion, the changes should show up on rule dev soon.
Let me know if there are any issues :)

Actions #11

Updated by Joseph Potvin about 1 year ago

  • Status changed from In Progress to Closed

This is working now, thank you.

Actions

Also available in: Atom PDF